Alexandre Julliard writes:
> I don't think your changes to MODULE_FindModule are correct. This will
> break lookup of any dll that is not in the path, for instance
> GetModuleHandle("foo.dll") must match foo.dll even if it was loaded
> from a private directory.
True, I have fixed this in a new version of the patch.
> Appending the system directory should only
> be done in BUILTIN32_LoadLibrary.
Hmm, I guess also in ELFDLL_LoadLibrary (as long as it is there)
and ELF_LoadLibrary, so I think the easiest way is to do it in
MODULE_LoadLibrary, since it boils down to a SearchPathA, if the
exists. Currently this is done in PE_LoadLibraryEx. If the library
does not exists and PE_LoadLibraryEx is still called (because of the
loadorder), CreateFile will fail in PE_LoadLibraryEx, so there is no
real change there.
> While you are at it, I'd suggest removing the ability to specify
> multiple dlls in the same option, and support repeated --dll options
> instead. The option syntax is way too complicated IMO.
done.
Greetings,
Peter
--
Peter Ganten
[EMAIL PROTECTED]
