Hi,


On Fri, 27 Oct 2000, Dmitry Timoshkov wrote:

> Hello.
> 
> Changelog:
>     Make bitmap menu items look like in windows when selected,
>     i.e. hilited and inverted.

   This patch does not seem right to me. I base this on my observations
of the behavior of the grafmenu, a smaple program of the Petzold 95. 
This program creates a menu containing black and white bitmaps and here
is what it looks like: 

 * in Win95
   - the normal display is black text on the regular gray background
   - when an item is selected its background becomes white, the text
stays black
   - except for the checkboxes which become white on the regular gray
background

 * in win98
   - same as Win95 when the window is active and the mouse is not over
the menu bar
   - if the window is inactive then the black parts become dark gray,
i.e. it looks the same as if we had a regular menu
   - when the mouse is over a menu bar item, there's a raised border
drawn around the bitmap (even if the window is inactive)
   - when a menubar item is selected, there is a sunken border drwan
around it and, unlike in Win95, the background remains grey
   - when a menu item is selected, it is highlighted like any other,
i.e. we have the dark blue background. But the bitmap is indeed
displayed kind of inverted. I get dark blue on white. And I also note
that the size of the menu item is calculated so that there is a 1 pixel
dark blue border above and below the bitmap.


   This is pretty complex and differs from what we get in Wine (with or
without your patch).
   I believe one of the problems in Wine lies in the calculation of the
item size: the sunken/raised border is overwritten by the bitmap so that
we don't see it. Then there's all the color and Win95 vs. Win98 aspects. 

   You can have a look at the URL below, it contains a screenshot of
grafmenu in Win95. I'll try to add other screenshots for Win98. 

http://fgouget.free.fr/wine/PrgWin95/Chap10.shtml#grafmenu

--
Francois Gouget         [EMAIL PROTECTED]        http://fgouget.free.fr/
      Broadcast message : fin du monde dans cinq minutes, repentez vous !



Reply via email to