Francois Gouget <[EMAIL PROTECTED]> wrote:
>> Actually my patch was addressing only fact, that bitmap menu items were
>> never neither hilited nor inverted. I've never took into account any
>> difference between Win95 and Win98 look either. But after your comments
>> I had a look on those difference, and implemented hopely right look in both
>> situations (only for hilited menu items). I think that it is a bug in windows95
>> - not draw hilited background for bitmap menu items.
>
> I think your patch should not have the NOTSRCCOPY BitBlt stuff. Win9x
>seems to just rely on properly setting the text and background colors.
Unfortunately I have no my own sample application that demonstrates behaviour
of menu bitmap items. Certainly I should write one. But in Adobe Pagemaker
bitmap menu items are _inverted_ in both win95 and win98. As I have noted,
win98 also draws hilited background for them.
> I built on your patch and propose the following instead. It's not
>exactly like Win98 but I think it looks even nicer. The reason is that
>the look of the checkmark and the bitmaps is consistent with both looks
>whereas in Windows they are not.
> BTW, what happens for color bitmaps? Can they be used???
Why not? :-)
>I've put up a couple screenshots showing how things look in Wine with
>my patch applied:
> Win95 look: http://fgouget.free.fr/wine/PrgWin95/grafmenu-wine952.png
> Win98 look: http://fgouget.free.fr/wine/PrgWin95/grafmenu-wine982.png
I still think that inversion is an essential part of the drawing selected
bitmap menu items. As the writing of the test app will consume some time,
I believe that my patch could be applied as is. It _is_ much better than
current behaviour. Alexandre?
Dmitry.
