On Fri, Jan 05, 2001 at 08:24:46PM -0800, Ryan Cumming wrote:
> This patch causes CDROM_GetLabel to always return zero in the event of
> failure. It some cases it was setting the label to an empty string and
> returning one, which prevented DRIVE_GetLabel from falling back to the
> drive label explicitly set in ~/.wine/config. With this patch I can get
> the "Red Alert: Aftermath" installer to run without commenting out the
> Device=/dev/scd1 line in my WINE config. I'm not posting this to
> wine-patches because I'm worried that the empty label string might have
> some significance. Any comments?
Yes. Doing that seems to be a Good Thing (tm).
However:
Maybe we should patch files/drive.c too ?
Or do we want "[Drive D]" returned as label in case the user didn't set
a label in the config file ?
Hmm, maybe we want it to be like that...
Andreas Mohr
