On Fri, Jan 05, 2001 at 09:09:57PM -0800, Ryan Cumming wrote:
> On 05 Jan 2001 22:44:07 -0600, Andreas Mohr wrote:
> > Yes. Doing that seems to be a Good Thing (tm).
> > However:
> > Maybe we should patch files/drive.c too ?
> > Or do we want "[Drive D]" returned as label in case the user didn't set
> > a label in the config file ?
> > Hmm, maybe we want it to be like that...
>
> I think returning a blank string is the best idea, in case some
> application depends on it's CD having a blank label. Here's the new
> patch, with one other change. It attempts to read the ISO9660 label,
> even on a mixed mode CD. This is actually successful on the "Red Alert:
> Aftermath" CD-ROM, allowing the installer to start up without setting
> the CD-ROM's label in my WINE config. I'm even more worried about that
> last change, hopefully the mixed mode CD-ROMs that caused problems for
> the author of that code will cause CDROM_Data_GetLabel to return zero
> instead of garbage ;).
Uuuuhh. I don't think this is a good idea.
This will result in media error output for certain types of mixed-mode
CDs, and I don't think we want that.
Better implement the "real" mixed-mode CD handling first...
(needs to use the "raw sector read" ioctl()s for that)
Andreas Mohr
