2008/8/21 Stefan Dösinger <[EMAIL PROTECTED]>:
> These changes may be correct, but they need a test. Take a look at 
> dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes 
> are likely to be correct, but they have to be tested
>
Not in its current form, there's a C++ comment and trailing spaces in
there, and the change in SetScissorRect() probably should test if the
rectangle is empty. Also, if it tests for empty rectangles, it should
probably also test for rectangles that are (partially) outside the
screen, etc.


Reply via email to