On Thu, Aug 21, 2008 at 9:41 PM, Stefan Dösinger <[EMAIL PROTECTED]>wrote:
> These changes may be correct, but they need a test. Take a look at > dlls/d3d9/tests/device.c to see how the other tests look. I guess the > changes are likely to be correct, but they have to be tested I'll add a test case and get back to you later then, thanks for the help. On Thu, Aug 21, 2008 at 9:51 PM, H. Verbeet <[EMAIL PROTECTED]> wrote: > > Not in its current form, there's a C++ comment and trailing spaces in > there, and the change in SetScissorRect() probably should test if the > rectangle is empty. Also, if it tests for empty rectangles, it should > probably also test for rectangles that are (partially) outside the > screen, etc. I'll change the code around and add the checking you mentioned. Thanks for the info. Regards, Andrew
