On 3 February 2010 19:37, Stefan Dösinger <[email protected]> wrote:
> the binary shader is pretty long. Wouldn't it be better to load the bytes 
> from an external file, or if that makes the tests too complicated, put the 
> DWORD[] into a separate .c or .h file?
>
In general we want the tests to be standalone as a single .c file.
Using 8 DWORDs per line might help a bit with the amount of vertical
space used though.

>> +    hr = D3D10CreateEffectFromMemory(fx_local_shader, fx_local_shader[6], 
>> 0, device, NULL, &effect);
> Is there a reason for using fx_local_shader[6] instead of 
> sizeof(fx_local_shader)? I see that the other tests do it as well.
>
They're not the same, the DWORD array contains 2 extra bytes padding
in this case. The first test mentions this in a comment, the others
don't. A simple wrapper function might help.


Reply via email to