Dan Kegel <[email protected]> writes: > On Fri, Jun 8, 2012 at 11:51 AM, Francois Gouget <[email protected]> wrote: >> On Fri, 8 Jun 2012, Dan Kegel wrote: >>> Isn't this a no-op? I thought that an undefined symbol was >>> treated as false by the preprocessor. >> >> Actually you may be right. But then this is the only place in Wine where >> we rely on this and I see not reason to make this assumption. Even more >> so since we don't for the other macros in the same test which makes this >> locally inconsistent. > > It feels funny to avoid using a basic feature of C... > maybe we should remove the extra defined() calls.
It's common practice to avoid it, to make things like -Wundef more useful. -- Alexandre Julliard [email protected]
