So compile wise, using 20080701 works, but some tests fail, looks like
an ordering issue in what is expected from the response.
For example:
JsonProviderTest.testGetJsonFeed with this dep returns:
----8<----
{"feed": {
"@xmlns": {"$": "http://www.w3.org/2005/Atom"},
"id": {
"$": "id",
"@xmlns": {"$": "http://www.w3.org/2005/Atom"}
},
"title": {
"$": "title",
"@type": "text",
"@xmlns": {"$": "http://www.w3.org/2005/Atom"}
}
}}
---->8----
But the test expects it to be:
----8<----
{"feed": {
"@xmlns": {"$": "http:\/\/www.w3.org\/2005\/Atom"},
"id": {
"@xmlns": {"$": "http:\/\/www.w3.org\/2005\/Atom"},
"$": "id"
},
"title": {
"@type": "text",
"@xmlns": {"$": "http:\/\/www.w3.org\/2005\/Atom"},
"$": "title"
}
}}
---->8----
Both look valid to me, unless I'm missing something. My guess is that
the tests should probably be augmented to be agnostic on the order of
keys in the map returned... ?
--jason
On Jul 1, 2009, at 7:43 PM, Jason Dillon wrote:
I started looking into this, looks like 20090211 was compiled with
Java 1.6, trying again with 20080701... grrr.
--jason
On Jul 1, 2009, at 7:38 PM, Bryant Luk wrote:
I think this is the same thing (I haven't done a diff) but should
also look at:
http://jira.codehaus.org/browse/JETTISON-66
to see if we can use the latest sources.
On Wed, Jul 1, 2009 at 4:59 AM, Jason Dillon<[email protected]>
wrote:
Is there any reason why we don't simply use the org.json:json:
20090211
dependencies instead of including these sources?
--jason
On Jul 1, 2009, at 3:22 PM, Jason Dillon wrote:
The following sources do not have the standard ASL 2.0 legal
header on
them:
wink-common/src/main/java/org/apache/wink/common/model/json/
JSONArray.java
wink-common/src/main/java/org/apache/wink/common/model/json/
JSONObject.java
wink-common/src/main/java/org/apache/wink/common/model/json/
JSONStringer.java
wink-common/src/main/java/org/apache/wink/common/model/json/
JSONTokener.java
wink-common/src/main/java/org/apache/wink/common/model/json/
JSONWriter.java
instead they have:
<snip>
/*
Copyright (c) 2002 JSON.org
Permission is hereby granted, free of charge, to any person
obtaining a
copy
of this software and associated documentation files (the
"Software"), to
deal
in the Software without restriction, including without limitation
the
rights
to use, copy, modify, merge, publish, distribute, sublicense, and/
or sell
copies of the Software, and to permit persons to whom the
Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be
included in
all
copies or substantial portions of the Software.
The Software shall be used for Good, not Evil.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
SHALL
THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING
FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN
THE
SOFTWARE.
*/
</snip>
Not sure what to do about this...
--jason
--
- Bryant Luk
