Fair enough. I still think we need to resolve the license of them wrt Wink though, but IANAL :-(

I recommend creating a wink-json module to hold onto these.

--jason


On Jul 5, 2009, at 7:07 PM, Fischer, Nadav wrote:

Sorry for the late response, I was out of office until today...

There were two reasons for not using json.org as a 3rd party dependency. First, we wanted to have as few as possible dependencies - it makes life easier for users. Second, the json library uses StringBuffer for all of its work, so to increase performance I changed all of the StringBuffer instances to StringBuilder.

It's true that using the json sources as part of our sources has the disadvantage of not progressing with the natural development of the json library, but at that time, the two advantages I mentioned above were more important.

So, do we stay with the modified json sources we have now or go with the json library as a separate dependency?

-Nadav

-----Original Message-----
From: Jason Dillon [mailto:[email protected]] On Behalf Of Jason Dillon
Sent: Wednesday, July 01, 2009 13:00
To: [email protected]
Subject: Re: Legal headers on org/apache/wink/common/model/json/*.java

Is there any reason why we don't simply use the org.json:json:20090211
dependencies instead of including these sources?

--jason


On Jul 1, 2009, at 3:22 PM, Jason Dillon wrote:

The following sources do not have the standard ASL 2.0 legal header
on them:

  wink-common/src/main/java/org/apache/wink/common/model/json/
JSONArray.java
  wink-common/src/main/java/org/apache/wink/common/model/json/
JSONObject.java
  wink-common/src/main/java/org/apache/wink/common/model/json/
JSONStringer.java
  wink-common/src/main/java/org/apache/wink/common/model/json/
JSONTokener.java
  wink-common/src/main/java/org/apache/wink/common/model/json/
JSONWriter.java

instead they have:

<snip>
/*
Copyright (c) 2002 JSON.org

Permission is hereby granted, free of charge, to any person
obtaining a copy
of this software and associated documentation files (the
"Software"), to deal
in the Software without restriction, including without limitation
the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or
sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be
included in all
copies or substantial portions of the Software.

The Software shall be used for Good, not Evil.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE
SOFTWARE.
*/
</snip>

Not sure what to do about this...

--jason



Reply via email to