Re: [VOTE] Release Wink 0.1

[Jason Dillon]

This is a very common problem with maven projects on windows.  IMO the  
solution is not to change the artifact names, but to instruct users to  
work under c:\<somedir> instead of whatever default windows wants to  
choose.  The space in the path may also mess up some builds and its  
highly advised *not* to build from there.

--jason

On Aug 9, 2009, at 8:37 PM, Bryant Luk wrote:

The problem with the names being long is that Windows users may
encounter issues when unzipping the source zips.  I think the path
limit is around 255 characters.  There's around 50 characters in the
c:\documents and settings\administrator\desktop\ already.

I've updated the pom.xml name elements so that during the Maven build
it looks better.  I think the artifactIds were properly updated but
please let me know if you see differently.

On Sun, Aug 9, 2009 at 4:47 AM, Jason Dillon<ja...@planet57.com>  
wrote:
Why did the name need shortening?  We should try to keep atrifactId's
consistent with the directory name they are defined in.  Its a best
practice.

--jason


On Aug 8, 2009, at 3:15 AM, Nicholas Gallardo wrote:


Kevan, a few responses to some of the issues.


wink-integration-test/wink-server-integration-test/wink-jaxrs- 
optional-providers/pom.xml,

Bryant fixed this before it was moved to "wink-itest" to shorten  
the name.

I assume that we have run the release binaries through the TCK?

Michael Elman ran the TCK on the tag.  Everything was good.

There are JIRAs opened for the other issues you mentioned.

-N



----- Original Message ----
From: Kevan Miller <kevan.mil...@gmail.com>
To: wink-dev@incubator.apache.org
Sent: Friday, August 7, 2009 2:12:35 PM
Subject: Re: [VOTE] Release Wink 0.1


On Aug 5, 2009, at 4:01 AM, Snitkovsky, Martin wrote:

Folks,

I'm calling a vote to release Wink 0.1

The Maven staging area is at:
https://repository.apache.org/content/repositories/wink- 
staging-014/

The distributions are in:

https://repository.apache.org/content/repositories/wink-staging-014/org/apache/wink/apache-wink/0.1-incubating/

This release is tagged at:
https://svn.apache.org/repos/asf/incubator/wink/tags/wink-0.1-incubating/

The vote will be open here for at least 72 hours.

Please consider this call to vote as my +1


As noted by Sebb, the top-level svn src directory needs to include  
the
LICENSE and NOTICE files. IMO, it should also include the  
DISCLAIMER and
 README/RELEASE-NOTES.

The SVN tag contains src/doc/release_notes.txt. However, the src
distribution does not. The src distribution does have license and  
notice
files in top-level, directory, though...

The file,
wink-integration-test/wink-server-integration-test/wink-jaxrs- 
optional-providers/pom.xml,
does not have an Apache source license header. It should.

Otherwise, the source looks good and build worked well for me.

I note that release_notes.txt states that "Apache Wink is TCK  
compliant
implementation of the JAX-RS v1.0 specification." I assume that we  
have run
the release binaries through the TCK?

The binary distribution contains two source jars:

lib/jaxb-api-2.1-sources.jar
lib/jaxb-impl-2.1.4-sources.jar

You cannot distribute these sources.

Finally, have the licenses of the included binaries (lib/*.jar) been
properly reviewed and documented, if required? Certainly the CDDL  
license
for the JAXB jars is missing. I can only guess that there are  
others...

Here's my -1 until the above issues have been resolved.

--kevan








--

- Bryant Luk