On Thu, Nov 30, 2017 at 06:57:20PM +0100, Jason A. Donenfeld wrote:
> On Thu, Nov 30, 2017 at 4:23 PM, Greg Kroah-Hartman
> <[email protected]> wrote:
> > It's good to have SPDX identifiers in all files as the Linux kernel
> > diff --git a/src/tools/config.c b/src/tools/config.c
> > index 6ff03767f9e6..312cbcdd7a85 100644
> > --- a/src/tools/config.c
> > +++ b/src/tools/config.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /* Copyright (C) 2015-2017 Jason A. Donenfeld <[email protected]>. All
> > Rights Reserved. */
> >
> > #include <arpa/inet.h>
> > diff --git a/src/tools/config.h b/src/tools/config.h
> > index 63a272cc1285..e3ad9f87404b 100644
> > --- a/src/tools/config.h
> > +++ b/src/tools/config.h
> > @@ -1,3 +1,4 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > /* Copyright (C) 2015-2017 Jason A. Donenfeld <[email protected]>. All
> > Rights Reserved. */
>
> It looks like you're giving .h a /* style comment and .c a // style
> comment. Is there a reason for this, or did you just have two
> different sed commands by accident?
There's is a reason for it, please see:
https://lwn.net/Articles/739183/
and the email thread on lkml about this, specifically the email with
this subject:
Subject: [patch V4 01/11] Documentation: Add license-rules.rst to
describe how to properly identify file licenses
It goes into why .c files should use // and why .h files should use /* */
thanks,
greg k-h
_______________________________________________
WireGuard mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/wireguard
