https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718

--- Comment #14 from Evan Huus <[email protected]> ---
Hi Fabio, looks pretty good. Two requests:

- Provide two patches if possible, one where you reorganize and one where you
actually add the new dissection. Otherwise it's very hard to review what's
actually changed vs just what's been moved.

- The buffer passed to BASE_CUSTOM dissectors is of size ITEM_LABEL_LENGTH, not
ZBEE_ZCL_DISPLAY_BUFFER_MAX_SIZE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
             mailto:[email protected]?subject=unsubscribe

Reply via email to