https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718
--- Comment #15 from Fabio Tarabelloni <[email protected]> --- Hi Evan, 1) ok for BASE_CUSTOM dissectors. I will replace ZBEE_ZCL_DISPLAY_BUFFER_MAX_SIZE to ITEM_LABEL_LENGTH 2) I understood to split extended patch to 2 single patches: a) OnOff cluster (currently set in packet-zbee-zcl-onoff.c file) moved to packet-zbee-zcl-general.c and onoff.c file removed. b) Other cluster dissector in files: - packet-zbee-zcl-ha.c - packet-zbee-zcl-meas-sensing.c - paket-zbee-zcl-general.c One question: where are Basic cluster and Identify cluster dissector placed? In patch a) or patch b) ? Because their patches are already uploaded but not completed. I think I have to place basic and identify mods in patch b). Thanks in advance for your suggestion. (In reply to comment #14) > Hi Fabio, looks pretty good. Two requests: > > - Provide two patches if possible, one where you reorganize and one where > you actually add the new dissection. Otherwise it's very hard to review > what's actually changed vs just what's been moved. > > - The buffer passed to BASE_CUSTOM dissectors is of size ITEM_LABEL_LENGTH, > not ZBEE_ZCL_DISPLAY_BUFFER_MAX_SIZE. -- You are receiving this mail because: You are watching all bug changes.
___________________________________________________________________________ Sent via: Wireshark-bugs mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
