Oh, I see. Sorry, must have missed that before. What Jaap writes in http://www.ethereal.com/lists/ethereal-dev/200604/msg00097.html is true, however IMHO I see no reason why not to fix this problem in this file (packet-tcp.h) right now. Why let Wireshark be Windows-app-development-a-like (you have to inlcude windows.h before including winsock2.h)? But I guess that it should be added to the Wiki wishlist that cleaning up include dependencies is a task to perform for anyone at will...
Regards, Peter Anders Broman wrote: > Hi, > The last time this was asked it was answered: > http://www.ethereal.com/lists/ethereal-dev/200604/msg00097.html > >> Hi, >> >> There doesn't seem to be a coding rule within the Ethereal code base that >> states that a header file itself must include the header files it depends >> on. If it is we have a whole lot of work to do... >> >> Thanx, >> Jaap >> > > >>> On Tue, 11 Apr 2006, Thomas Boehne wrote: >>> > > >>> My dissector includes packet-tcp.h, which uses se_tree_t from emem.h >>> without including it. Could someone please add an >>> >>> #include <epan/emem.h> >>> >>> to packet-tcp.h? Or is there a special reason for not including it? >>> >>> Regards, >>> Thomas >>> >>> > > Brg > Anders > > -----Ursprungligt meddelande----- > Från: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] För Peter Johansson > Skickat: den 20 september 2006 11:14 > Till: Developer support list for Wireshark > Ämne: [Wireshark-dev] Patch to packet-tcp.h > > This is a resend of a patch I sent September 8th, it seems to have been > misplaced somwhere ;) > > / Regards, Peter > _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
