Hi, checked in as rev21390 with the following modifications : - use of proto_tree_add_item whenever possible (addition of several hf_items), - use distinct subtree idx for each subtree, - addition of some subtrees, - split shim_opts in several functions, - accurate incrementation of offset in locator preferences (in case of option length > 3) - add true_false_string for critical options and protocol differentiation (hip, shim6) - add shim6.cksum_good, shim6.cksum_bad, cksum expert info
Have you put a little description of shim6 on the wireshark wiki? (First chapter of your thesis? :)) Regards, Sebastien Tandel Matthijs Mekking wrote: > Hello, > > > - in hf_register_info, there are two items of the same name : > > hf_ipv6_shim6_opt_len > > This is fixed in the source and in the patch. > > > - you should create an helper function to add hf_ipv6_shim6_ct to > the tree. > > I know, but at the moment I don't have the time to figure that out. > > > - instead of dissect_shim_ip_addr, use > > proto_tree_add_item/proto_tree_add_ipv6. The type of the item is then > > FT_IPv6. > > Replaced all occurences of dissect_shim_ip_addr. > > In two weeks time I should have more time. Than I will look at the > hf_ipv6_shim6_ct. Expect a new patch at that time. > > Regards, > > Matthijs > _______________________________________________ Wireshark-dev mailing list [EMAIL PROTECTED] http://www.wireshark.org/mailman/listinfo/wireshark-dev _______________________________________________ Wireshark-dev mailing list [EMAIL PROTECTED] http://www.wireshark.org/mailman/listinfo/wireshark-dev
