-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Never mind,
I have misunderstood your e-mail. You made modifications, not requests :). I have found rev21390 and looked at it. Looks good :) Thanks. Regards, Matthijs Matthijs Mekking wrote: > Ok, found some time to work at SHIM6 Wireshark, but I'm not that > familiar with the revisions system. Some questions: > >>> checked in as rev21390 with the following modifications : > > Where can I find this? > >>> - use distinct subtree idx for each subtree, > > Not sure what you mean here... > >>> - addition of some subtrees, > > Currently I use two additional subtrees: for the shim6 extension header > and for the shim6 options field. Where would you like to see more subtrees? > >>> - add shim6.cksum_good, shim6.cksum_bad, cksum expert info > > What is cksum expert info? > >>> - you should create an helper function to add hf_ipv6_shim6_ct to the > tree. > > something like proto_tree_add_ctxtag_format ? > >>> >>> Have you put a little description of shim6 on the wireshark wiki? (First >>> chapter of your thesis? :)) >>> > > I shall look for a short description > > > Regards, > Matthijs Mekking > > >>> >>> Regards, >>> Sebastien Tandel >>> >>> >>> Matthijs Mekking wrote: >>>> Hello, >>>> >>>>> - in hf_register_info, there are two items of the same name : >>>>> hf_ipv6_shim6_opt_len >>>> This is fixed in the source and in the patch. >>>> >>>>> - you should create an helper function to add hf_ipv6_shim6_ct to >>>> the tree. >>>> >>>> I know, but at the moment I don't have the time to figure that out. >>>> >>>>> - instead of dissect_shim_ip_addr, use >>>>> proto_tree_add_item/proto_tree_add_ipv6. The type of the item is then >>>>> FT_IPv6. >>>> Replaced all occurences of dissect_shim_ip_addr. >>>> >>>> In two weeks time I should have more time. Than I will look at the >>>> hf_ipv6_shim6_ct. Expect a new patch at that time. >>>> >>>> Regards, >>>> >>>> Matthijs >>>> >>> _______________________________________________ >>> Wireshark-dev mailing list >>> [email protected] >>> http://www.wireshark.org/mailman/listinfo/wireshark-dev >>> >>> >>> _______________________________________________ >>> Wireshark-dev mailing list >>> [email protected] >>> http://www.wireshark.org/mailman/listinfo/wireshark-dev >>> > _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGMKOvNiaStnTWEtYRAgSUAJ0aKo+amqajY3cCSCOo+YCeY2fIygCghTXh n1cMjdsE7L+VccjBVCNHaCg= =z0zw -----END PGP SIGNATURE----- _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
