Thanks Chris. It probably doesn't do much harm to install the XML file without the plugin that uses them, but it would be better if I change it to install them only if plugins have been selected. Or maybe I'll make it a built-in sooner rather than later. I'm still fighting the windows buildbot at the moment...
On 10/12/07, Maynard, Chris <[EMAIL PROTECTED]> wrote: > > Plugin installation is optional. See attached setup.exe snapshot. > > > ------------------------------ > > *From:* [EMAIL PROTECTED] [mailto: > [EMAIL PROTECTED] *On Behalf Of *Martin Mathieson > *Sent:* Friday, October 12, 2007 6:07 AM > *To:* Developer support list for Wireshark > *Subject:* Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1903] > wimaxasncp:TLVsdefined in XML files > > > > Done. > > At a glance, I don't think the installation of the plugins is optional - > could someone verify this? > I can't test the win32 installer until I get home tonight... > > On 10/11/07, *Anders Broman* <[EMAIL PROTECTED]> wrote: > > If it's going to be built in can't it have it's own directory together > with Diameter, Radius etc so we don't have to move it later? > > Regards > > Anders > > > ------------------------------ > > *Från:* [EMAIL PROTECTED] [mailto: > [EMAIL PROTECTED] *För *Martin Mathieson > *Skickat:* den 11 oktober 2007 19:15 > *Till:* [email protected] > *Ämne:* Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1903] wimaxasncp: > TLVsdefined in XML files > > > > > > On 10/11/07, [EMAIL PROTECTED] <[EMAIL PROTECTED] > > wrote: > > http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1903 > > > ------- Comment #11 from [EMAIL PROTECTED] 2007-10-11 > 09:34 GMT ------- > Just to be clear - I was thinking of people having the flexibility to > offer the > very latest plugin code (taken from the main svn repo) with a stable > release of > Wireshark (perhaps supplied by their distro). > > Rather than people distributing private modifications of the plugin. > > Anyway, the updated plugin has had some more testing. Can we decide now > where > the XML file should be installed (I don't think this patch changed > wireshark.nsi...) ? > > > Any ideas what to do with this? The patched version seems to work > equivalently to the current version that doesn't use XML for the TLVs. The > immediate issue seems to be where the XML should be installed. It is > currently written (during a 'make install' to the data direction, e.g. on > my machine here /usr/local/share/wireshark/plugins/wimaxasncp). Should it > instead go in the plugins folder with the plugin itself? I couldn't find > any other precedents for plugins installing extra files. Does this seem to > be acceptable? If so, I'll add the entry needed to wireshark.nsi and check > it in tomorrow. > > I don't think anyone disagrees that it can become a built-in dissector > once it and the WiMAX standard matures a bit more. > > Regards, > Martin > > > > > _______________________________________________ > Wireshark-dev mailing list > [email protected] > http://www.wireshark.org/mailman/listinfo/wireshark-dev > > > > ------------------------------ > > * This email may contain confidential and privileged material for the sole > use of the intended recipient(s). Any review, use, retention, distribution > or disclosure by others is strictly prohibited. If you are not the intended > recipient (or authorized to receive for the recipient), please contact the > sender by reply email and delete all copies of this message. Also, email is > susceptible to data corruption, interception, tampering, unauthorized > amendment and viruses. We only send and receive emails on the basis that we > are not liable for any such corruption, interception, tampering, amendment > or viruses or any consequence thereof. * > > _______________________________________________ > Wireshark-dev mailing list > [email protected] > http://www.wireshark.org/mailman/listinfo/wireshark-dev > > >
_______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
