Hi, Indeed this was done to find/eliminate some tricky crashes of Wireshark. Like with proto_add_*(), which has the requirement for tree! =NULL removed, the col_*() functions are now hardened against ! check_col(). Still it's not wrong to test for it, and most, if not all, still does. With the branch of 1.2 on the horizon I would suggest holding off this 'housekeeping' issue until we're working on 1.3.
Just my €0.02 Jaap Sent from my iPhone On 13 mei 2009, at 15:29, Jakub Zawadzki <[email protected]> wrote: > Hi, > > In r27806 stig add checking for col existence in col_*() function, so > it's no longer need to call check_col() before setting column data > (?). > However it's still used in dissectors and even worse check_col() is > used > in new written code. > > My proposal is to add check_col() as deprecated function in > checkAPIs.pl > any comments? > > Cheers > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
