On Wed, May 13, 2009 at 04:44:26PM +0200, Jaap Keuter wrote:
> Indeed this was done to find/eliminate some tricky crashes of
> Wireshark. Like with proto_add_*(), which has the requirement for tree!
> =NULL removed, the col_*() functions are now hardened against !
> check_col().
> Still it's not wrong to test for it, and most, if not all, still does.
> With the branch of 1.2 on the horizon I would suggest holding off this
> 'housekeeping' issue until we're working on 1.3.
Hmm, how about removing that function and adding an empty #define for
it in the .h file and #undefine it in the .c file after including
the .h-file. If no new problems come up, people may safely remove that stuff
any time they want and the initial patch isn't big.
Ciao
Joerg
--
Joerg Mayer <[email protected]>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <[email protected]>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:[email protected]?subject=unsubscribe
