Hi >This goes along the lines of my thinking that we could turn off sorting >until a capture file is fully loaded. We could also only turn on sorting >if the user clicks on one of the column headings by using a number for >sort_id to signify no sorting.
That seems to work any way, I've checked in the change. Regards Anders -----Ursprungligt meddelande----- Från: [email protected] [mailto:[email protected]] För Stephen Fisher Skickat: den 2 juli 2009 19:36 Till: Developer support list for Wireshark Ämne: Re: [Wireshark-dev] New experimental feature: GTK2 basedpacket list(svn rev 28892) On Thu, Jul 02, 2009 at 10:13:54AM +0200, Anders Broman wrote: > Great job! Looks quite good I think. Thanks! I'm going to work on the coloring rules next. > I played with it a bit and loading large files is quite slow but > removing the resorting for every row speeds it up to be faster than > the original code I think. A 61Mb trace New packet list with patch > ~11s, old WS (SVN Rev 27374) ~16s Great. > Memmory usage is much higher though 183 744Kb vs 252 388K. Should some > columns be stored as numbers instead of strings? Probably. > Index: packet_list_store.c > =================================================================== > --- packet_list_store.c (revision 28916) > +++ packet_list_store.c (working copy) > @@ -516,7 +516,7 @@ > > gtk_tree_path_free(path); > > - packet_list_resort(packet_list); > + //packet_list_resort(packet_list); > } This goes along the lines of my thinking that we could turn off sorting until a capture file is fully loaded. We could also only turn on sorting if the user clicks on one of the column headings by using a number for sort_id to signify no sorting. Steve ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
