On Aug 14, 2009, at 11:38 PM, [email protected] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29427 > > User: krj > Date: 2009/08/14 11:38 PM > > Log: > This patch introduces packet_add_new_data_source() which effectively > deprecates add_new_data_source(). This is based on the following > observation: > > 1) The tvb + name (aka. data_source) is only used when the protocol > tree is visible
Nope. It's also used, for example, by "tshark -x", even if "-V" isn't specified. There may be other places where it's used as well. I've checked in a change to remove the test for a non-null, visible protocol tree. If this optimization is to be done, we need a better way of determining whether the data sources will be used. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
