On May 9, 2016, at 9:31 AM, Yang Luo <[email protected]> wrote: > I want to enable monitor mode column for Windows. Based on this post: > https://www.wireshark.org/lists/wireshark-dev/201601/msg00002.html, we need > to undefine the HAVE_PCAP_OPEN macro when building Wireshark for Windows.
No. It "means that dumpcap needs to be changed to use those APIs on local adapters if they're available, regardless of whether pcap_open() is available, and to use pcap_open() *only* for remote adapters." And that's already been done in the master branch. See caputils/capture-pcap-util.c and caputils/capture-wpcap.c. > As Guy said, it seems that the drawback for this patch is acceptable (losing > support of WinPcap 4.1 earlier) No - on Windows, it "[chooses] whether to use pcap_create() *et al* at run time" - perhaps I didn't want to have to do that at the time, but I eventually did it anyway. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
