Hi Guy, Alexis, I have seen the monitor mode column in the latest development version: Wireshark-win64-2.1.0-3054-gad4d0b8.exe. Thanks!
Cheers, Yang On Mon, May 16, 2016 at 4:32 AM, Guy Harris <[email protected]> wrote: > On May 15, 2016, at 10:49 AM, Yang Luo <[email protected]> wrote: > > > On Sun, May 15, 2016 at 4:29 AM, Guy Harris <[email protected]> wrote: > >> On May 9, 2016, at 9:31 AM, Yang Luo <[email protected]> wrote: > >> > >>> I want to enable monitor mode column for Windows. Based on this post: > https://www.wireshark.org/lists/wireshark-dev/201601/msg00002.html, we > need to undefine the HAVE_PCAP_OPEN macro when building Wireshark for > Windows. > >> > >> No. > >> > >> It "means that dumpcap needs to be changed to use those APIs on local > adapters if they're available, regardless of whether pcap_open() is > available, and to use pcap_open() *only* for remote adapters." > >> > >> And that's already been done in the master branch. See > caputils/capture-pcap-util.c and caputils/capture-wpcap.c. > > > > I saw these 3 commits as below (I think these are what you mean by > "that's already been done in the master branch"?): > > > > 1) Add opiton to configure HAVE_PCAP_CREATE > > > https://github.com/wireshark/wireshark/commit/4a408c9641cd5e5a62064d4e4f545f7fe38b7dbb > > 2) [WINPCAP] First step to be able to use pcap_create() > > > https://github.com/wireshark/wireshark/commit/1658a3520f79d63217b47015b244a82bd55d3f34 > > 3) Set both HAVE_PCAP_CREATE and HAVE_PCAP_OPEN. > > > https://github.com/wireshark/wireshark/commit/b2bf9e3306d34987dfb7928964931088c2224b92 > > No, I also mean, for example: > > 4) Move more capture device handling to the caputils library. > > https://github.com/wireshark/wireshark/commit/ba3aa03dcfb49a3bb2b090b864f1311fa4ecbc0e > > > These commits happen in 7 Jan, and Wireshark 2.0.3 which I use is > released on Apr 23. So I think these commits work for 2.0.3. > > The *date* of a commit doesn't matter - a commit done on the master > branch, after the 2.0 branch was created, won't be in any 2.0.x release, > even if it's done before the release. It would have to be done on the 2.0 > branch in order to be in a 2.0 release. > > ba3aa03dcfb49a3bb2b090b864f1311fa4ecbc0e was *not* done on the 2.0 branch, > only on the master branch, so it's not in *any* 2.0.x release. > > As Alexis said, you should be using the master branch, not the 2.0 branch, > to test your work. > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected] > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
