Bugs item #1546224, was opened at 2006-08-24 16:15
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1546224&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: votive
Group: v2.0
Status: Open
Resolution: None
Priority: 5
Submitted By: shirata (shirata)
Assigned to: Justin Rockwood (justinrockwood)
Summary: problem with candle arguement -out with trailing \

Initial Comment:
wix-2.0.4415.0

In votive, candle arguement -out has extra " if the 
output directory has a trailing \.

FIX:

We should escape the backlash and not add another 
quote.

ConstructCommandLineParameters in CandleSetting.cs

string outParam = PackageUtility.QuoteString
(relativeOutputFileDir);
if (PackageUtility.EndsWith(outParam, @"\""", 
StringComparison.Ordinal))
{
  outParam += "\"";
}

should be

string outParam = relativeOutputFileDir;
if (PackageUtility.EndsWith(outParam, "\\", 
StringComparison.Ordinal))
{
        outParam += "\\";
}
outParam = PackageUtility.QuoteString(outParam);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1546224&group_id=105970

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to