Bugs item #1546224, was opened at 2006-08-24 13:15
Message generated for change (Settings changed) made by justinrockwood
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1546224&group_id=105970
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: votive
Group: v2.0
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: shirata (shirata)
Assigned to: Justin Rockwood (justinrockwood)
Summary: problem with candle arguement -out with trailing \
Initial Comment:
wix-2.0.4415.0
In votive, candle arguement -out has extra " if the
output directory has a trailing \.
FIX:
We should escape the backlash and not add another
quote.
ConstructCommandLineParameters in CandleSetting.cs
string outParam = PackageUtility.QuoteString
(relativeOutputFileDir);
if (PackageUtility.EndsWith(outParam, @"\""",
StringComparison.Ordinal))
{
outParam += "\"";
}
should be
string outParam = relativeOutputFileDir;
if (PackageUtility.EndsWith(outParam, "\\",
StringComparison.Ordinal))
{
outParam += "\\";
}
outParam = PackageUtility.QuoteString(outParam);
----------------------------------------------------------------------
Comment By: shirata (shirata)
Date: 2006-08-24 13:20
Message:
Logged In: YES
user_id=1373564
oops... the fix should check to see if the path doesn't end
in \\ already before we append the extra \.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1546224&group_id=105970
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs
