Bugs item #1546218, was opened at 2006-08-24 13:06
Message generated for change (Comment added) made by justinrockwood
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1546218&group_id=105970
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: votive
Group: v2.0
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Private: No
Submitted By: shirata (shirata)
Assigned to: Justin Rockwood (justinrockwood)
Summary: problem with spaces in wixproj's RelativeOutputDirectory
Initial Comment:
related to Bug 1511034
WixProj that has RelativeOutputDirectory with spaces
has the spaces replaced with %20 in the light command
arguements.
Fix:
In PackageUtility.MakeRelative(), System.Uri should
used the Uri(string, bool) constructor.
public static string MakeRelative(string basePath,
string pathToMakeRelative)
{
Uri baseUri = new Uri(basePath);
Uri relativeUri = new Uri(pathToMakeRelative);
should be
public static string MakeRelative(string basePath,
string pathToMakeRelative)
{
Uri baseUri = new Uri(basePath, true);
Uri relativeUri = new Uri(pathToMakeRelative,
true);
----------------------------------------------------------------------
>Comment By: Justin Rockwood (justinrockwood)
Date: 2006-12-19 22:07
Message:
Logged In: YES
user_id=1054914
Originator: NO
Fixed in Votive v3. I know this is apparently an easy fix (thanks for the
code that needs to change), however, it's a little trickier than it might
seem on the surface. This particular method has a branch for compiling with
.NET 1.1 vs. .NET 2.0. The Uri(string, bool) constructor was deprecated in
.NET 2.0. To make this change, I'd have to regression test both VS 2003, VS
2005 using .NET 1.1 and .NET 2.0. The regression test matrix is too high
for this change and this method is used throughout the entire system.
Sorry. :(
----------------------------------------------------------------------
Comment By: shirata (shirata)
Date: 2006-08-24 13:08
Message:
Logged In: YES
user_id=1373564
This is for wix-2.0.4415.0.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1546218&group_id=105970
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs
