Ship it. On 22-Feb-13 16:56, Rob Mensching wrote:
FYI, the pull request for this change is out now. I'm quite happy how this cleans up the code and adds a bit of nice functionality. The next feature here would be to add more user interaction... something for the future.On Wed, Feb 20, 2013 at 11:00 PM, Rob Mensching <r...@robmensching.com <mailto:r...@robmensching.com>> wrote:I only want the close part of the RM API and none of the rest. Basically, I want to send the messages and not worry about it otherwise. CloseApplications is used when you don't necessarily want a restart registered. RestartResource is more appropriate if you want the RM behavior. On Wed, Feb 20, 2013 at 3:22 PM, Heath Stewart <hea...@outlook.com <mailto:hea...@outlook.com>> wrote: Then why not call the RM APIs (if available)? The documentation for apps integrating with RM are to save state temporarily for lParam == ENDSESSION_CLOSEAPP. Sure, there's enough documentation to effectively do what RM does but that could change in the future. At some point, WiX will only support OSes where RM is always available. *Heath Stewart* VS Pro Deployment Experience, Microsoft http://blogs.msdn.com/heaths *From:*Wesley Manning [mailto:wmann...@dynagen.ca <mailto:wmann...@dynagen.ca>] *Sent:* Wednesday, February 20, 2013 2:37 PM *To:* Windows Installer XML toolset developer mailing list *Subject:* Re: [WiX-devs] RFC: CloseApps extension enhancements. 1.If application returns no on WM_QUERYENDSESSION then you wouldn't send WM_ENDSESSION? 2.How much time between WM_QUERYENDSESSION before calling WM_ENDSESSION? Is this the 5s you where talking about below? *From:*Rob Mensching [mailto:r...@robmensching.com] *Sent:* February 20, 2013 5:29 PM *To:* Windows Installer XML toolset developer mailing list *Subject:* Re: [WiX-devs] RFC: CloseApps extension enhancements. 1. The new code will be new code. If you don't use the new attributes nothing will change. I'm planning to to this in wix38 (should have mentioned that) so it must be backwards compatible. 2. The SCM will do whatever it is directed to do when the process crashes based on the service configuration. Getting killed looks nearly identical to crashing (I think your process ends with a different return code). On Wed, Feb 20, 2013 at 1:02 PM, Neil Sleightholm <n...@x2systems.com <mailto:n...@x2systems.com>> wrote: Sounds good but a couple of thoughts: 1.I seem to remember find issues with the original implementation of CloseApplications with tray applications, might be worth making sure the new code doesn't break anything (in my case it was a VB6 application!) 2.What would happen if someone tried to kill a service? I can think of a good reason to do this but it might be worth checking the outcome. Neil *From:*Rob Mensching [mailto:r...@robmensching.com <mailto:r...@robmensching.com>] *Sent:* 20 February 2013 20:20 *To:* Windows Installer XML toolset developer mailing list *Subject:* [WiX-devs] RFC: CloseApps extension enhancements. I was using CloseApplications from the WixUtilExtension recently and found I needed a bit more functionality than what is currently present. Here's what I'm thinking about adding: 1. Add "EndSessionMessage" and "ElevatedEndSessionMessage" attributes - this will more mimic the Restart Manager behavior where a WM_QUERYENDSESSION then WM_ENDSESSION is sent. Those messages seem to be more in vogue that sending a WM_CLOSE these days. I'm not planning to do it exactly like RM where all apps are sent a query message before sending the end session messages. I'm just going to do each message back to back (unless the query says don't try to end). I'm doing this because I found some apps that got unhappy being told to close. I'm not married to those attribute names. 2. Add "TerminateProcess" attribute - this will act similar to the existing RebootMessage attribute but kill the process instead of scheduling a restart. Killing processes is generally a bad thing but I've run into a couple customers now that say that is the correct way to close their process that has no window. I'm not married to that attribute name but "KillProcess" seemed a little aggressive. <smile/> 3. (if I have time) Add a "Timeout" attribute - this will allow each CloseApplication element to change the default wait when doing a close. Right now the default is hardcoded to 5 seconds which seems reasonable, but if I have time, I thought I'd allow it to be configurable. Any questions, concerns, suggestions? ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net <mailto:WiX-devs@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net <mailto:WiX-devs@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
-- sig://boB http://joyofsetup.com/
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
