Okay, I walked through the pull request. I had a number of questions there
plus a few things that need to be looked at. Overall, I think this is
probably the best way to fix the issue. Thanks for sending.
As noted in the pull request, this is one of those cases where sending pull
requests for each separate bug would have been much clearer. Spent a bit of
time trying to make sure I understood which change was fixing which bug.
Separate pull requests also increases bug fix rate since one bug doesn't
get blocked in code review if a different bug has issues.
On Sun, Jul 14, 2013 at 10:13 AM, Rob Mensching <r...@robmensching.com>wrote:
> VS uses WiX toolset so they would be affected by the same bug. <smile/>
>
>
> On Wed, Jul 10, 2013 at 10:15 AM, Hoover, Jacob <
> jacob.hoo...@greenheck.com> wrote:
>
>> It is, and it’s even in existence within the MS packages. I found
>> Blend_Core.msi from the VS 11 Ultimate Beta to have a cert but not have
>> validation. (Yes, I was digging in crazy locations to see what I was doing
>> wrong.)****
>>
>> ****
>>
>> ** **
>>
>> *From:* Rob Mensching [mailto:r...@robmensching.com]
>> *Sent:* Wednesday, July 10, 2013 12:10 PM
>>
>> *To:* Windows Installer XML toolset developer mailing list
>> *Subject:* Re: [WiX-devs] SFBUG: 3341/3340****
>>
>> ** **
>>
>> Ahh, that's an interesting (separate) bug if true.****
>>
>> ** **
>>
>> On Wed, Jul 10, 2013 at 10:08 AM, Georg von Kries <g...@creativbox.net>
>> wrote:****
>>
>> I have seen that MsiDatabaseImport does not add entries in the
>> _Validation table if the imported table does not exist before. Are those
>> entries required anyways? It triggers an ICE03 error “Missing data in
>> _Validation table or old Database”, but I have no idea if this is actually
>> something to fix.****
>>
>> ****
>>
>> Kind regards,****
>>
>> Georg****
>>
>> ****
>>
>> *Von:* Rob Mensching [mailto:r...@robmensching.com]
>> *Gesendet:* Mittwoch, 10. Juli 2013 16:38****
>>
>>
>> *An:* Windows Installer XML toolset developer mailing list
>> *Betreff:* Re: [WiX-devs] SFBUG: 3341/3340****
>>
>> ****
>>
>> Re: ::MsiDatabaseImport()****
>>
>> ****
>>
>> It is a bit of a pain to debug when there are failures however:****
>>
>> ****
>>
>> 1. MsiDatabaseImport is a couple orders of magnitude faster to create the
>> MSI over using the SQL queries.****
>>
>> ****
>>
>> 2. MsiDatabaseImport creates the smallest MSI files. The SQL
>> insert/update queries can add "hot air" to an MSI so we want to minimize
>> their use to what is absolutely necessary.****
>>
>> ****
>>
>> On Tue, Jul 9, 2013 at 10:57 AM, Hoover, Jacob <
>> jacob.hoo...@greenheck.com> wrote:****
>>
>> When looking at SFBUG 3340 and 3341, I attempted to prefix the
>> identifier. Any time I use anything other than the hash it fails to
>> import. I’ve tried multiple variations (_, cer, Z, etc) of a prefix. Each
>> time I have verified that the certificate name in the IDT matches that of
>> the file on disk in the MsiDigitalCertificate sub folder. I’ve tried it
>> with only changing the identifier and with changing both the identifier and
>> the file name.****
>>
>> ****
>>
>> By chance is there something mis-documented on either the table
>> definition or the MsiDatabaseImport function? (Is there a reason we are
>> using this instead of using the DB functions directly?)****
>>
>> ****
>>
>> It may be worth mentioning that I can’t even adjust this value with Orca.
>> It fails on commit with “The data was rejected by the database. It may be
>> out of the valid range or formatted incorrectly”. I can modify the
>> identifier in the MsiDigitalSignature table, and I can modify another
>> record in the MsiDigitalCertificate table. (I have a local fix that leaves
>> the named key from the MsiPatchCertificate table in place.) The only other
>> unique thing I can think of is both certs are identical.****
>>
>> ****
>>
>> Thanks,****
>>
>> Jacob ****
>>
>> ****
>>
>>
>>
>> ------------------------------------------------------------------------------
>> See everything from the browser to the database with AppDynamics
>> Get end-to-end visibility with application monitoring from AppDynamics
>> Isolate bottlenecks and diagnose root cause in seconds.
>> Start your free trial of AppDynamics Pro today!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> _______________________________________________
>> WiX-devs mailing list
>> WiX-devs@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/wix-devs****
>>
>> ****
>>
>>
>>
>> ------------------------------------------------------------------------------
>> See everything from the browser to the database with AppDynamics
>> Get end-to-end visibility with application monitoring from AppDynamics
>> Isolate bottlenecks and diagnose root cause in seconds.
>> Start your free trial of AppDynamics Pro today!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> _______________________________________________
>> WiX-devs mailing list
>> WiX-devs@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/wix-devs****
>>
>> ** **
>>
>>
>>
>> ------------------------------------------------------------------------------
>> See everything from the browser to the database with AppDynamics
>> Get end-to-end visibility with application monitoring from AppDynamics
>> Isolate bottlenecks and diagnose root cause in seconds.
>> Start your free trial of AppDynamics Pro today!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> _______________________________________________
>> WiX-devs mailing list
>> WiX-devs@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/wix-devs
>>
>>
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
