Was out of country this week and next week is looking bleak as well. If I can
get on I'll push for more discussion next Thursday.
Sent from my iPhone
On Jan 28, 2014, at 10:15 AM, "Blair Murri"
<os...@live.com<mailto:os...@live.com>> wrote:
I wouldn’t rate a second interface as a breaking change (it is additive and
IMHO it doesn’t “really” change the behavior) but it does add a layer of
complexity that isn’t optimal.
You should add it to the agenda for Thursday. I think the idea definitely has
merit. Then again Rob’s vetoed my ideas for inclusion in 3.x before based on
back-compat issues milder than this one.
Blair
From: Hoover, Jacob<mailto:jacob.hoo...@greenheck.com>
Sent: Saturday, January 25, 2014 7:35 AM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
I could also implement a second interface, and utilize QueryInterface to get to
it. I don’t want the change to require this feature be pushed to 4.0, but at
the same time I don’t want to make it overly cumbersome for the 3.x developers
to use.
I know we have the goal of never breaking the signature of a method in a point
release, but for existing native users this would simply mean adding NULL as
the parameter.
I don’t think there was ever a Binary compatibility without recompile claim.
Jacob
From: Blair Murri [mailto:os...@live.com]
Sent: Thursday, January 23, 2014 10:56 PM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
It’s COM but not IDispatch. Because of that it’s still a breaking change (it
would require recompiling the consumers to recognize the optional argument). VB
will, on recompile, ignore the optional argument (putting in a placeholder
behind the scenes). C++ requires a code change.
Blair
From: Sean<mailto:rhal...@hotmail.com>
Sent: Thursday, January 23, 2014 5:14 PM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Sorry, I didn't realize this was a COM interface, I haven't been able to get
into the toolset code like I want to. Also, I haven't created any COM
interfaces. After some Googling, it looks like the only way to "overload"
would be if you mark the new HWnd argument as optional and make it a variant?
________________________________
From: r...@robmensching.com<mailto:r...@robmensching.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Fri, 24 Jan 2014 00:39:54 +0000
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
It’s C++ code. An COM interface in this case (to interact well with managed
code as well as native code). How would you do a function overload in this case?
From: Sean [mailto:rhal...@hotmail.com]
Sent: Thursday, January 23, 2014 4:25 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
I guess 4.0 then. It doesn't make sense to me to add a new function that will
do the exact same thing.
Is there any plans for dropping C support so you can do modern things like
overload a function? :) (or I guess it's <smile/> in this group?)
Maybe add a SetDetectWindow(HWnd) for 3.x?
________________________________
From: r...@robmensching.com<mailto:r...@robmensching.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Thu, 23 Jan 2014 16:59:47 +0000
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
I should have been explicit, all current users of Burn will be broken when they
upgrade from WiX v3.8 (or less) to WiX v3.9. We don’t do that in dot releases.
I think the change is fine, but to do so would require taking it in WiX v4
(where breaking changes are expected).
From: Sean [mailto:rhal...@hotmail.com]
Sent: Thursday, January 23, 2014 8:57 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
Since Apply already requires an HWnd, I actually don't think it's a big deal to
change Detect to require one, too.
Sean
________________________________
From: r...@robmensching.com<mailto:r...@robmensching.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Thu, 23 Jan 2014 16:41:21 +0000
Subject: [WiX-devs] Self update bundles, the detect issue.
>From this pull request:
>https://wix.codeplex.com/SourceControl/network/forks/jchoover/Wix/contribution/5911
> I’m looking for more input on the issue surround the
>IBootstrapperEngine::Detect() signature changing. I see a couple ways around
>this:
1. Move the pull request to WiX v4.0 where we can “break” (in this case:
enhance) the Detect API as we see fit.
2. Add another method to the IBootstrapperEngine called
“DetectWIthUpdates()” or something (Jacob already proposed something like
“Detect2()” which is not high on my list of good names <smile/>).
Personally, I’m leaning towards option #1. Option #2 isn’t completely horrible
but there are already ways to skip update detection (if it is slow, for
example) and adding a top level method seems overkill.
Comments? Suggestions?
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More
Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development
Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More
Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development
Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More
Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development
Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
