My understanding is that the SAL annotation is just for static analysis. The
default argument (“= NULL”) is the important part. I just wasn’t sure it’d work
in the interface but knowing that it does, I guess I’m not completely surprised.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, February 6, 2014 9:25 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
I’m in meetings today so I can’t be in the online meeting. I need to do some
more testing to verify the change, but I don’t think per say it was breaking
since I had the HWND as __in_opt. In fact, even without the interface change
(assigning = 0) it still compiles. I think that’s the wonderful MSVC compiler
doing what it’s told.
(From http://msdn.microsoft.com/en-us/library/ms235402(v=vs.80).aspx)
_opt
The pointer to the buffer might be NULL. It will be checked before being
dereferenced.
From: Rob Mensching [mailto:r...@robmensching.com]
Sent: Thursday, February 06, 2014 10:36 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
Yes, agreed. If the default works then this works in 3.x.
It has always been required that when you take a new drop of the WiX toolset
(any new drop) that you recompile the world. Subtle things can change that we
make sure a clean compile/lit/link handle.
From: Blair Murri [mailto:os...@live.com]
Sent: Wednesday, February 5, 2014 9:38 PM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
With the recompile requirement then adding the default argument should be fine
for 3.x IMHO. I had thought we were avoiding recompiles whenever possible.
Blair
From: Rob Mensching<mailto:r...@robmensching.com>
Sent: Wednesday, February 05, 2014 1:48 PM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Wow, I’m really surprised that works. However, if it does, awesome.
The rule is pretty simple with only a couple qualifications
1. When WiX toolset users take a minor release of the WiX toolset they
must recompile all of their WiX related code (.wxs, extensions, custom actions,
etc). That recompile should compile without any new issues.
2. Except:
a. A WiX Toolset user cannot patch MSIs with different versions of the
WiX toolset (even build number changes). It might work sometimes but it
definitely won’t work all the time. Patching is just too sensitive to changes
for us to make this always work.
b. We will make breaking changes for security or really bad bugs whenever
necessary. We will apologize profusely but bad stuff cannot be allowed to live.
So, if changes can be made to the Burn engine and balutil/mba such that
wixstdba and WixBA do not require code changes then all of the above is
satisfied.
Is that clearer?
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
