Thought I’d jump in as 3736 is mine. Other than the SQL install (probably the 
worst installation package I have ever seen) I have not found another install 
where this would be required. It would be handy for SQL but should we really 
cater for such bad installs? Not at all sure how this applies to 4413.

Neil

From: Rob Mensching [mailto:r...@firegiant.com]
Sent: 07 May 2014 19:38
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] WIXFEAT:4413 Add WixBundleNumberOfApplyPhases

The difference between this variable and the variable in #3736 (path to cache) 
is that the path to the cache would be useful to provide on the command-line to 
an ExePackage element. The number of times apply is going to be executed is 
only really useful to the BA for its progress bar and thus not a good candidate 
for a Variable.

I’ll let Bob weigh in on the way to incorporate this into WiX v3.x (if at all 
<smile/>).  It sounds like you agree the best change in WiX v4.0 is to enhance 
the interface, which is cool.  So, if this does get added as a variable in WiX 
v3.x then I guess it gets added as deprecated right out of the gate (which is 
kinda’ odd).

PS: I think pulling pull request discussions here is generally “A Good Thing”.

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  
http://www.firegiant.com/

From: Sean Hall [mailto:r.sean.h...@gmail.com]
Sent: Monday, May 5, 2014 2:43 PM
To: WiX toolset developer mailing list
Subject: [WiX-devs] WIXFEAT:4413 Add WixBundleNumberOfApplyPhases

I'm going to bring this one to wix-devs, too.

Sure, that's how to do it in v4.0.  But what's the alternative in v3.9?  Add a 
new callback in IBootstrapperApplication?  What about feature requests like 
http://wixtoolset.org/issues/3736/, where they're asking for a global variable 
that has an even narrower scope?

p.s. Note to self: pull request comment emails may not give the whole comment.
On Mon, May 5, 2014 at 2:57 PM, Rob Mensching 
<notificati...@github.com<mailto:notificati...@github.com>> wrote:

I really don't like this as a global variable that is only useful during the 
Apply() lifetime. This really should be a value provided to OnApplyBegin(). 
It's at the perfect place for it.

—
Reply to this email directly or view it on 
GitHub<https://github.com/rseanhall/wix3/commit/6a959bde176089275bf845f0a4086ad2b6dd15d1#commitcomment-6216248>.

------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to