Rob/Bob,
Should I focus on trying to fix the feed or should I make the native parser
more tolerant of the feed that we currently are publishing? I've fixed the
version handling, but the missing application identity is causing the entire
feed to be ignored.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 4:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
<code>
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry->wzApplicationId && !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
</code>
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a "v" in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the "v" concept.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of <as:version> (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement->wzValue, &dwMajor, &dwMinor) which does not
like the v prefix.
Thanks,
Jacob
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
