Since we're meeting tomorrow, I opened a bug.

On 31-Jul-14 13:11, Sean Hall wrote:
Are you going to resubmit it? It does fix Jacob's issue, it's just no one filed a bug on it.


On Thu, Jul 31, 2014 at 12:08 PM, Bob Arnson <b...@joyofsetup.com <mailto:b...@joyofsetup.com>> wrote:

    You're right, it doesn't fix 4481; I got confused based on the
    thread. I pulled the pull request.

    On 31-Jul-14 12:50, Sean Hall wrote:
    4481 is a new problem introduced because DetectComplete gets
    called twice when the update causes detect to fail the first
    time.  Disabling the update button doesn't fix this problem.


    On Thu, Jul 31, 2014 at 11:46 AM, Hoover, Jacob
    <jacob.hoo...@greenheck.com <mailto:jacob.hoo...@greenheck.com>>
    wrote:

        Is that a new problem introduced with my changes, or a
        pre-existing bug?  The bigger fix is to disable the button
        while an update is being checked.

        -----Original Message-----
        From: Bob Arnson [mailto:b...@joyofsetup.com
        <mailto:b...@joyofsetup.com>]
        Sent: Thursday, July 31, 2014 11:31 AM
        To: wix-devs@lists.sourceforge.net
        <mailto:wix-devs@lists.sourceforge.net>
        Subject: Re: [WiX-devs] WixToolset.org issue...

        On 31-Jul-14 11:14, Sean Hall wrote:
        > No meeting today?  It's starting to feel like not having a
        meeting is
        > the norm.
        It just feels that way because it's been two weeks in a row.
        :) I used to have an O365 account but let it lapse because I
        never used it. I'm not sure there's a good alternative to a
        paid Lync account. Maybe a Google Hangout, though it's
        limited to 10 users, I think. That's just about how many
        people we get weekly. Not sure it has a recording feature...

        > I think #2 is the fix for the issue I submitted already:
        > http://wixtoolset.org/issues/4481/
        Mostly. My easy fix solves the easy problem. Turns out the
        general problem is bigger: If an update is available, you can
        click the Update button any number of times, even during
        apply. It looks like nothing's happening but it's busy
        downloading the update and will kick it off when it's done.
        It's neat having half a dozen WiX installers running though a
        bit unnerving to have them keep popping up when you thought
        you were done...

        --
        sig://boB
        http://joyofsetup.com/


        
------------------------------------------------------------------------------
        Infragistics Professional
        Build stunning WinForms apps today!
        Reboot your WinForms applications with our WinForms controls.
        Build a bridge from your legacy apps to the future.
        
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
        _______________________________________________
        WiX-devs mailing list
        WiX-devs@lists.sourceforge.net
        <mailto:WiX-devs@lists.sourceforge.net>
        https://lists.sourceforge.net/lists/listinfo/wix-devs

        
------------------------------------------------------------------------------
        Infragistics Professional
        Build stunning WinForms apps today!
        Reboot your WinForms applications with our WinForms controls.
        Build a bridge from your legacy apps to the future.
        
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
        _______________________________________________
        WiX-devs mailing list
        WiX-devs@lists.sourceforge.net
        <mailto:WiX-devs@lists.sourceforge.net>
        https://lists.sourceforge.net/lists/listinfo/wix-devs




    
------------------------------------------------------------------------------
    Infragistics Professional
    Build stunning WinForms apps today!
    Reboot your WinForms applications with our WinForms controls.
    Build a bridge from your legacy apps to the future.
    http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk


    _______________________________________________
    WiX-devs mailing list
    WiX-devs@lists.sourceforge.net  <mailto:WiX-devs@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/wix-devs

-- sig://boB
    http://joyofsetup.com/


    
------------------------------------------------------------------------------
    Infragistics Professional
    Build stunning WinForms apps today!
    Reboot your WinForms applications with our WinForms controls.
    Build a bridge from your legacy apps to the future.
    http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
    _______________________________________________
    WiX-devs mailing list
    WiX-devs@lists.sourceforge.net <mailto:WiX-devs@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/wix-devs




------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk


_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs

--
sig://boB
http://joyofsetup.com/

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to