Pull request is send.
From: Rob Mensching [mailto:r...@firegiant.com] Sent: Monday, August 11, 2014 10:23 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] wix-devs@lists.sourceforge.net Can you please send this as a pull request? It can be merged into the project correctly then. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset | <http://www.firegiant.com/> http://www.firegiant.com/ From: Norbert Schulze [ <mailto:norbert-schu...@online.de> mailto:norbert-schu...@online.de] Sent: Monday, August 11, 2014 1:14 PM To: <mailto:wix-devs@lists.sourceforge.net> wix-devs@lists.sourceforge.net Subject: [WiX-devs] <mailto:wix-devs@lists.sourceforge.net> wix-devs@lists.sourceforge.net On 24-Nov-2013 I filed a bug that „Firewall port list or range is not possible“ http://wixtoolset.org/issues/4206/. This bug was than relabeled as feature request. IMO it’s nevertheless a bug, because all the other code that handles the firewall port parameter can already handle port lists as it uses the string type for the parameter. Only in firewall.cpp an integer is used. So can somebody with write access to the repository please check in the small attached patch which changes the type of the variable iPort from integer to string. Best regards, Norbert
------------------------------------------------------------------------------
_______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
