Thank you for the tutorials. Hopefully my first pull request is correct now.
From: Heath Stewart [mailto:hea...@outlook.com] Sent: Tuesday, August 12, 2014 1:43 AM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] wix-devs@lists.sourceforge.net Http://help.github.com has some good ones. Http://git-scm.com/book is good in general. Sent from my Windows Phone _____ From: Norbert Schulze <mailto:norbert-schu...@online.de> Sent: 8/11/2014 4:24 PM To: 'WiX toolset developer mailing list' <mailto:wix-devs@lists.sourceforge.net> Subject: Re: [WiX-devs] wix-devs@lists.sourceforge.net <mailto:wix-devs@lists.sourceforge.net> Right now I don’t know how to do a pull request. Can you recommend a good tutorial? From: Rob Mensching [mailto:r...@firegiant.com] Sent: Monday, August 11, 2014 10:23 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] wix-devs@lists.sourceforge.net <mailto:wix-devs@lists.sourceforge.net> Can you please send this as a pull request? It can be merged into the project correctly then. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Norbert Schulze [mailto:norbert-schu...@online.de] Sent: Monday, August 11, 2014 1:14 PM To: wix-devs@lists.sourceforge.net <mailto:wix-devs@lists.sourceforge.net> Subject: [WiX-devs] wix-devs@lists.sourceforge.net <mailto:wix-devs@lists.sourceforge.net> On 24-Nov-2013 I filed a bug that „Firewall port list or range is not possible“ http://wixtoolset.org/issues/4206/. This bug was than relabeled as feature request. IMO it’s nevertheless a bug, because all the other code that handles the firewall port parameter can already handle port lists as it uses the string type for the parameter. Only in firewall.cpp an integer is used. So can somebody with write access to the repository please check in the small attached patch which changes the type of the variable iPort from integer to string. Best regards, Norbert
------------------------------------------------------------------------------
_______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
