Wow, terrifying. Code so old, I've forgotten lame limitations built into it.
I'll keep it in the back of my mind and maybe go in and improve it... that's
just a scary (unexpected) limitation.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Heath Stewart [mailto:hea...@outlook.com]
Sent: Monday, September 29, 2014 9:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] LogExitOnFailure question
WcaErrorMessage already had that stipulation. But at least on 32-bit builds it
wouldn't matter for LPCWSTR or INT.
Heath Stewart
Software Design Engineer
Visual Studio, Microsoft
http://blogs.msdn.com/heaths
________________________________
From: r...@firegiant.com<mailto:r...@firegiant.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Mon, 29 Sep 2014 18:36:33 +0000
Subject: Re: [WiX-devs] LogExitOnFailure question
1. LogExitOnFailure() - the function itself makes sense. It's just like
ConsoleExitOnFailure() or other named exit on failure methods. I believe it'd
only be used in Burn since we tried using messages for most error messages, so
it's relatively new.
2. WcaErrorMessage() - "stipulation that all arguments passed to it are
strings" is that a safe thing to do? Seems very reasonable that
WcaErrorMessage() could get passed numbers, no?
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Heath Stewart [mailto:hea...@outlook.com]
Sent: Saturday, September 27, 2014 6:24 PM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Subject: Re: [WiX-devs] LogExitOnFailure question
I guess this is really more of a question about possibly breaking clients of
dutil, but I think this is worth it. In this specific case, we're getting rid
of what's otherwise an unnecessary function so far as I can tell.
I was able calculate the arguments passed to WcaErrorMessage (which has macro
functions as well), with the existing stipulation that all arguments passed to
it are strings. If only the ANSI standard put some more weight behind variadic
args!
Heath Stewart
Software Design Engineer
Visual Studio, Microsoft
http://blogs.msdn.com/heaths
________________________________
From: hea...@outlook.com<mailto:hea...@outlook.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Sat, 27 Sep 2014 16:52:17 -0700
Subject: [WiX-devs] LogExitOnFailure question
I'm working on checking in variadic macros to the public fork (these have been
a productivity boost internally - no more having to refactor/edit error
messages and forgetting to change the macro number at the end) but ran across a
set I didn't change before and don't think I'll be able to (safely) now.
LogExitOnFailure(X) is used only twice in the entire wix source tree, and I'm
curious as to why as opposed to LogErrorId/ExitFunction.
This the only one I can't do anything about, it seems, because you can't modify
va_args (I tried out a few ideas with some limited success but it's
runtime-dependent, so not safe/supported).
I wouldn't remove or change these for wix3 (I even leave the old variants like
ExitOnFailure1, but just redirect to ExitOnFailure which uses variadic macros),
but if we're looking at some clean-up in wix4 that would be good (I was
planning on removing all traces of numbered functions in favor of the variadic
ones).
Heath Stewart
Software Design Engineer
Visual Studio, Microsoft
http://blogs.msdn.com/heaths
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS
3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready
for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0
Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Slashdot TV. Videos for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
