Breaking change to BVariantCopy(). What if we always use the encryption state
of Source and always nuke Target’s encryption state (like you are on
variant.cpp:271)? Then we just need to get the Source state set correctly
before copying.
I think that makes a lot of sense anyway, right? Target encryption state
matches Source encryption state on success.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Sean Hall [mailto:r.sean.h...@gmail.com]
Sent: Tuesday, November 25, 2014 11:47 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Just opened bug 4609 against v3.9
Here's how I would fix it:
https://github.com/rseanhall/wix3/commit/e14695eeac02b82f7d2ed392606cd1c8a670a7ab
On Tue, Nov 25, 2014 at 1:37 PM, Rob Mensching
<r...@firegiant.com<mailto:r...@firegiant.com>> wrote:
It’s okay. I missed in code review as well. Anyway, we started digging into
this at FireGiant and I expect we’ll have a pull request against WiX v3.10 very
shortly.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Sean Hall [mailto:r.sean.h...@gmail.com<mailto:r.sean.h...@gmail.com>]
Sent: Tuesday, November 25, 2014 6:36 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Just opened bug 4609 against v3.9
That's pretty embarrassing, I did all that work to try to encrypt the value and
it doesn't actually stay encrypted. I agree with your analysis and proposed
fix.
I don't know what the process would be, but if you already have the change
ready then I would go ahead and submit a pull request to the develop branch for
wix3.
On Tue, Nov 25, 2014 at 8:16 AM, John Cooper
<jocoo...@jackhenry.com<mailto:jocoo...@jackhenry.com>> wrote:
That’s probably why I haven’t seen it. All of our cases are elevated.
--
John Merryweather Cooper
Senior Software Engineer | Enterprise Service Applications | Continuing
Development
Jack Henry & Associates, Inc.® | Lenexa, KS 66214 | Ext: 431050
|jocoo...@jackhenry.com<mailto:jocoo...@jackhenry.com>
From: Blair Murri [mailto:os...@live.com<mailto:os...@live.com>]
Sent: Monday, November 24, 2014 11:46 PM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Subject: [WiX-devs] Just opened bug 4609 against v3.9
http://wixtoolset.org/issues/4609/ is the issue I mentioned in the previous
weekly meeting. It isn't as bad as we first thought, but it does cripple at
least one use case (setting a default value for a hidden variable) and (at
least in the non-elevated UI engine instance, I did not look in the elevated
apply engine instance) it actually stores the plaintext version of its values,
not the encrypted one (there is no case where they are stored encrypted).
If you want I could post a pull request against wixtoolset/wix3/master branch
with my proposed fix, but I want to have some of you discuss whether you think
this is a show stopper or not (my current client can live with the limitations
for now).
Blair
NOTICE: This electronic mail message and any files transmitted with it are
intended
exclusively for the individual or entity to which it is addressed. The message,
together with any attachment, may contain confidential and/or privileged
information.
Any unauthorized review, use, printing, saving, copying, disclosure or
distribution
is strictly prohibited. If you have received this message in error, please
immediately advise the sender by reply email and delete all copies.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
