My original idea was to create a BVariantSetVariant(__in BURN_VARIANT*
pVariant, __in BURN_VARIANT* pValue), but I scrapped it since it was almost
an exact copy of BVariantCopy. Maybe that was the right way to go? I just
wish I was right on the first pull request way back when :)
Hmm, I wonder if I introduced that inefficiency in the XML parsing?
Hopefully not.
Note2: That's why I didn't submit it in a pull request :) I find it's much
easier to talk about code changes when you can actually see it.
On Tue, Nov 25, 2014 at 3:35 PM, Rob Mensching <r...@firegiant.com> wrote:
> Ahh, yes, right. The root issue is that the Source encryption state is
> rarely set “correctly”. I 100% agree that using the target’s encryption
> state is weird. I guess what is needed is a “BVariantCopyEx()” (better
> name’s welcome) that is what you had originally to specify the final
> desired encryption state (i.e. you were right).
>
>
>
> I still stand by my comment though that the variables parsing from XML
> using variant as it does is pretty inefficient. <wink/>
>
>
>
>
>
> Note: the FireGiant change was the direct fix that was tested to unblock
> other processes happening here.
>
>
>
>
>
> Note2: The comment “// Encryption here (and decryption later inside
> BVariantCopy) could have been optimized away with breaking change.” is
> going look very strange over time. It’s much better for comments to explain
> why something was done vs. explaining that something that was not done
> could have been done. The latter will be very confusing (or frustrating)
> trying to figure out what the actual issue is. <smile/>
>
>
>
>
>
> _______________________________________________________________
>
> FireGiant | Dedicated support for the WiX toolset |
> http://www.firegiant.com/
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
