I've done some more thinking about this. I think Rob's main objection with making Product/@Id optional was that someone might accidentally forget to specify it. However, what if we displayed a warning to the user whenever they omitted the Property/@Id attribute informing them that doing so is non-standard and would result in generating a new ProductCode for each build - thus making it impossible to do anything other than major upgrades.
I think would be ideal because it: 1. Keeps the schema consistent - omitting the Id attribute generates an identifier/guid. 2. Warns users of the specific dangers of generating a ProductCode every time (so it provides more user education than the current tools). 3. Doesn't really prevent a user from getting back to a good state if they really did want to specify a ProductCode since they can always go back and hard-code in a ProductCode when they discover that building patches using images with different ProductCodes does not work. I'm also thinking of adding a similar warning if a user sets the Package/@Id attribute for a Product because that would produce identical PackageCodes for multiple msi files, which is against MSI recommendations and may result in undesirable behavior in some scenarios as well. Derek -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Derek Cicerone Sent: Wednesday, August 02, 2006 1:24 AM To: 'DEÁK JAHN, Gábor'; 'WiX-users' Subject: Re: [WiX-users] rfc: Package element changes That's correct - we generate the entire guid every time. Derek -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of DEÁK JAHN, Gábor Sent: Wednesday, August 02, 2006 1:14 AM To: WiX-users Subject: [WiX-users] rfc: Package element changes On Tue, 1 Aug 2006 16:44:39 -0400, Dave Williamson wrote: Dave, > I assume that "12345678-????-????-????-??????5??????" makes up all > the GUID parts except for 12345678 and 5. Somebody correct me if I'm wrong but as far as I know GUIDs are always created complete. There is no such thing as partial GUID creation. A GUID is only then can be guaranteed unique if it is generated fresh in every respect. Bye, Gábor ------------------------------------------------------------------- DEÁK JAHN, Gábor -- Budapest, Hungary E-mail: [EMAIL PROTECTED] ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
