Hello,
I have two little comments about your patch proposal:
1) Your proposal doesn't implement this point of my patch, which is
unrelated to the escape key handling:
- If all windows are minimized, the first one in the list is selected,
instead of the second.
The related part of my patch is:
@@ -110,7 +111,10 @@
oldFocused = wwin;
if (swpanel) {
- newFocused = wSwitchPanelSelectNext(swpanel, !next);
+ if (wwin->flags.mapped)
+ newFocused = wSwitchPanelSelectNext(swpanel, !next);
+ else
+ newFocused = wSwitchPanelSelectFirst(swpanel, False);
if (newFocused) {
wWindowFocus(newFocused, oldFocused);
oldFocused = newFocused;
2) Is it really necessary to handle the escape key apart from the home
and end keys? This induces some code duplication.
+ } else if (ev.xkey.keycode == escapeKey) {
+ /* Focus the first window of the swpanel */
+ newFocused = wSwitchPanelSelectFirst(swpanel,
0);
+ if (newFocused) {
+ wWindowFocus(newFocused, oldFocused);
+ oldFocused = newFocused;
+
+ if (wPreferences.circ_raise) {
+ CommitStacking(scr);
+ raiseWindow(swpanel,
newFocused);
+ }
+ }
+ esc_cancel = True;
+ done = True;
} else if (ev.xkey.keycode != shiftLKey &&
ev.xkey.keycode != shiftRKey) {
Kind Regards,
Nicolas
--
To unsubscribe, send mail to [email protected].
