Hi,

Carlos, I think that your new code to avoid code duplication and to
handle the escape key is great!

I have another (almost unrelated) suggestion: when all windows are minimized, the switch panel cursor is initially on the second window in the list. With this patch it will be on the first window.

--- src/cycling.c.old   2009-08-22 12:19:37.000000000 +0200
+++ src/cycling.c       2009-08-22 12:21:33.000000000 +0200
@@ -120,9 +120,12 @@
        oldFocused = wwin;

        if (swpanel) {
-               newFocused = wSwitchPanelSelectNext(swpanel, !next);
-               if (newFocused)
- oldFocused = change_focus_and_raise(newFocused, oldFocused, swpanel, scr);
+            if (wwin->flags.mapped)
+                newFocused = wSwitchPanelSelectNext(swpanel, !next);
+            else
+                newFocused = wSwitchPanelSelectFirst(swpanel, False);
+           if (newFocused)
+ oldFocused = change_focus_and_raise(newFocused, oldFocused, swpanel, scr);
        } else {
                if (wwin->frame->workspace == scr->current_workspace)
                        newFocused = wwin;


Regards,
Nicolas


--
To unsubscribe, send mail to [email protected].

Reply via email to