Hello, nice that someone get a bit closer to wmaker's code. I made also some changes, getopt (wm/wprefs) is working, the event-structure is more lean and clean. At the moment i am working on the key/mouse handling, which is really a mess.
I think it's a good idea to delete XSMP support and i would also delete files like wsmap. There is a repository, so it makes no sense to keep the files. For the wanted functionality, i recommend bugs.windowmaker.info with a proper hint to the deleted files at starting point. What about LITE? I would like to have some opinions on that, i think it's really useless. I would rather clean up the code, and decide later, a lite version. 2009/12/6 Carlos R. Mafra <[email protected]> > On So 6.Dez'09 at 3:08:34 +0100, Nicolas Bonifas wrote: > > > > [properties.c:1]: (style) The function 'PropGetWindowRole' is never used > > Yes, but this is also inside a > > #ifdef XSMP_ENABLED > > which is a much bigger unused part (eg it is half of src/session.c code). > Perhaps it would make sense to remove everything related to XSMP_ENABLED, > because it is never defined. It seems that XSMP is a major unfinished work > left behind. > > > [menureader.c:1]: (style) The function 'ReopenRootMenu' is never used > > [menureader.c:1]: (style) The function 'pl_openMenuFile' is never used > > The whole file menureader.c is actually unused. I've just deleted it now. > > > [startup.c:1]: (style) The function 'delayedAction' is never used > > Yeah, this is related to the patches to have wmaker with 0 wakeups when > idle. I will let it there for the time being. > > > [defaults.c:1]: (style) The function 'getRImages' is never used > > Gone. > > > [session.c:1]: (style) The function 'iceIOErrorHandler' is never used > > This is inside the same never-defined XSMP_ENABLED I mentioned above. > There does not seem to be anyone working to finish the XSMP_ENABLED > stuff... > > > [startup.c:1]: (style) The function 'wHackedUngrabButton' is never used > > [icon.c:1]: (style) The function 'wIconSetHighlited' is never used > > [pixmap.c:1]: (style) The function 'wPixmapCreateFromBitmap' is never > used > > Gone. > > > [wsmap.c:1]: (style) The function 'wShowWorkspaceMap' is never used > > [wsmap.c:1]: (style) The function 'handleEvent' is never used > > The whole file is unused. But I will let it there because having > that functionality is one of the things I dream about. > > > [window.c:1]: (style) The function 'wWindowCheckAttributeSanity' is > > never used > > Gone. > > Should appear in 'next' soon. And I will also send the patches to > the list in case people are interested. > > > -- > To unsubscribe, send mail to [email protected] > . >
