On Thu, Feb 17, 2011 at 3:40 PM, Carlos R. Mafra <[email protected]> wrote:

> On Thu, 17 Feb 2011 at 14:56:36 -0200, Haroldo Santos wrote:
> > Dear All,
> >
> > Some applications running in my machine are only background windows,
> e.g.:
> > screenlets showing CPU usage.
> >
> > In current wmaker version all these applications pollute my switchpanel,
> so
> > I wrote this patch (thanks Carlos for the helping me).
> > It includes an additional advanced option for windows:
> >   "Do not include in switchpanel"
>
>
> diff --git a/src/winspector.c b/src/winspector.c
> index d01646a..60228a9 100644
> --- a/src/winspector.c
> +++ b/src/winspector.c
>
> ...
>
> -       for (i = 0; i < 9; i++) {
> +       for (i = 0; i < 11; i++) {
>                int flag = 0;
>
> This part looked odd to me at first sight. It turns out that you fixed a
> off-by-one
> bug in there at the same time, right?
>

Exactly.

>
> I think the same problem also exists a bit further down, in
>
>       if (panel->appFrm && wapp) {
>                for (i = 0; i < 2; i++) {
>                        int flag = 0;
>
>                        switch (i) {
>                        case 0:
>                                flag = WFLAGP(wapp->main_window_desc,
> start_hidden);
>                                break;
>                        case 1:
>                                flag = WFLAGP(wapp->main_window_desc,
> no_appicon);
>                                break;
>                        case 2:
>                                flag = WFLAGP(wapp->main_window_desc,
> shared_appicon);
>                                break;
>                        }
>
> Would you mind sending a patch for that too (in case you agree)?
>
I included also the second fix in the patch now.

[]'s



>
>
> --
> To unsubscribe, send mail to [email protected]
> .
>



-- 
=============================================================
Haroldo Gambini Santos
Computing Department - Universidade Federal de Ouro Preto - UFOP
email: haroldo [at ] iceb.ufop.br
home/research page: www.decom.ufop.br/haroldo/

"Computer science is no more about computers than astronomy
is about telescopes." Edsger Dijkstra

Attachment: skipsp2.patch
Description: Binary data

Reply via email to