Great patch! I tested it now and it works pretty well and I liked the funcionality it adds.
On Sun 11.Oct'09 at 22:10:14 +0200, Johann Haarhoff wrote: > I realize this duplicates some of the Mod+button3 functionality, > but Mod+button3 just never seems to do the Right Thing(tm). Heh, until now I didn't even know about Mod+button3 so I "tested" it too and it is also quite nice. So it is like "two patches" in one email! :-) But why do you say Mod+button3 never seems to do the Right Thing? From my limited testing of it, it seems to depend heavily on where you hit the button3 (left x right halves or up and bottom halves). It seems to work fine for me. > There is a possible improvement where the vertical scroll-wheel resizes > vertically, > and the horizontal wheel resizes horizontally, Couldn't you map different Mod keys for them? Say Mod1 for vertical and Mod2 for horizontal resize? > Getting the slider into WPrefs was also quite a tight fit. Yeah, it looks squeezed right there. Perhaps you could rephrase the "Open dialogs in the same workspace as their owners" of the panel to the left to shorten it and divide that panel into two? > This currently ignores wWindowConstrainSize > until I can figure out a way to repeatably resize windows with > fixed size increments (like xterm) using this method. What do you want to do with wWindowConstrainSize()? Your patch seems to work fine without it. > This also adds a slider to WPrefs to choose the increment with which > the wheel will resize a window. This option is very useful, as I set it to a high value and then it gets resized very quickly. In general I am quite happy with this new way of resizing windows, and I will definitely use it daily. But now that I also "discovered" Mod+button3 I will also use it too! In fact one of the most common resizes I do is to enlarge _horizontaly_ my xterms when some command gets too big. Until now the lame way I did that was with Ctrl+ESC --> Resize/Move and then Crtl+(right arrow). But your patch does not address the horizontal-only resize, and it would be really nice if you find a way to do that (perhaps with different mod keys). Your patch is already on 'next', btw. Thanks Johann! -- To unsubscribe, send mail to [email protected].
