Quoting "Carlos R. Mafra" <[email protected]>:
Great patch! I tested it now and it works pretty well and I liked
the funcionality it adds.
I'm glad you like it. I found that once I got used to this way of
resizing, I hardly use anything else.
But why do you say Mod+button3 never seems to do the Right Thing? From my
limited testing of it, it seems to depend heavily on where you hit the
button3 (left x right halves or up and bottom halves). It seems to work
fine for me.
Ahhh, well you see, that is what I could never figure out. I didn't
realize that the resize was dependent on where button3 gets clicked.
So I never really found a nice way to use it because I could never
determine in advance which edges would be resized. Maybe I'll grow to
like it now that I know how it works.
Couldn't you map different Mod keys for them? Say Mod1 for vertical
and Mod2 for
horizontal resize?
Yes, I can have a look at this.
What do you want to do with wWindowConstrainSize()? Your patch seems
to work fine without it.
Some applications (like xterm) like to be resized in fixed-size
increments (multiples of terminal lines). If you do not respect this,
you will get some blank space below the last terminal line which can
look a bit confusing. wWindowConstrainSize() talks to the app and will
return the closest width and height to what you requested, but taking
into account the fixed-size increments.
Unfortunately, this does not work well with the wheel resize, since
adding a fixed amount of pixels to both dimensions will sometimes be
enough to get you an extra column, but not an extra line. Uncomment
the two wWindowConstrainSize lines in my patch, and you will see what
I mean.
But your patch does not address the horizontal-only resize, and it would
be really nice if you find a way to do that (perhaps with different mod
keys).
Unfortunately I'll be away from my computer for the next 10 days or
so, so I won't be able to do anything about it soon. I don't mind if
anyone else adds this though.
Your patch is already on 'next', btw.
Thank you for your very speedy handling of patches, and great feedback.
Regards,
Johann
-----------------------------------------------------
This message was sent using Obsidian SWiTCH web-mail.
Obsidian SWiTCH - an Obsidian Systems company.
(0860) 055-911 - http://www.switch-it.co.za/
--
To unsubscribe, send mail to [email protected].
