On Wed, 15 Sep 2010, Bento Loewenstein wrote: hi,
> here's a patch for a crash scenario on WPrefs (described on the patch > blurb). With the aditional benefit of removing an ugly "goto" from the > code. am i reading this right what it does is turn any unknown menu type into an implicit exec? if so, i'm full body weight against it. errors in the menu should be pointed out (and generators fixed), not hidden. preventing the crash is best done by making the caller recognize and act upon null returned from parsecommand(). wings proplist is there for a reason, it should be used when generating proplists (i mean, you aren't writing xml by hand either...), just look at the dances in the first incarnation of wmgenmenu. > when i saw that goto there i thought i was halucinating or something, > but it's gone now and sanity restored. gotos are not necessarily bad :) in fact, in this original scenario, it's perfectly fine. -- [-] mkdir /nonexistent -- To unsubscribe, send mail to [email protected].
