On Thu, Sep 16, 2010 at 12:16 PM, Tamas TEVESZ <[email protected]> wrote:

> am i reading this right what it does is turn any unknown menu type
> into an implicit exec? if so, i'm full body weight against it. errors
> in the menu should be pointed out (and generators fixed), not hidden.
> preventing the crash is best done by making the caller recognize and
> act upon null returned from parsecommand().

the way I did, it does point out, by filling the command with "invalid
command". it's better than what it was before. before, it was just
calling  wwarning() to print a message on stderr (which is useless for
an end user if it's lauched from an icon or menu) before segfaulting.

as soon as i get home i'll take another look. maybe pop a warning
before dropping the entry.

Bento Loewenstein


-- 
To unsubscribe, send mail to [email protected].

Reply via email to