On 15/01/12 21:22, Carlos R. Mafra wrote: > On Sun, 15 Jan 2012 at 20:56:04 +0100, [email protected] wrote: >> Hello, >> >> May I suggest a small fix in the patch? >> I have attached the same patch with the proposed fixes, which are: >> - the declaration of 'alpha_combine' has no reason to be inside the >> same-name file; >> - however, this definition is missing before use in the other files >> (actually only "wraster.c", but that's the idea) which generate a dangerous >> warning (bug risk!) >> >> To which I did this: >> - moved the declaration in "wraster.h" so it can be visible in the needed >> place; >> - added inclusion of this header in alpha_combine.c to report errors on >> declaration mismatch; > > Thanks for the proper review and for the (important) edits on top > of Rodolfo's patch. > > Rodolfo, is it OK if I apply his patch with his authorship and add a > comment in the commit log about your first version?
Yes, feel free. :-) >> - renamed the function to "RCombineAlpha" to have a name consistent with >> the other functions declared in the header. > > You mentioned trolling, right? So here it goes :-) > > One day if someone writes a sed script converting all CamelCased > atrocities into proper names so that the flames will not fall only > over me, that will be a happy day. > > And after that glorious event, being consistent will not be a > nuisance :-) > > -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
